Skip to content

fix: malformed cookie payload #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BRUHItsABunny
Copy link
Contributor

Fixes #344

@Juktong
Copy link

Juktong commented May 21, 2025

Hi @BRUHItsABunny,

Thanks for this PR! I'm new to the uTLS codebase and have been reading through it, hoping to contribute.

I've reviewed the CookieExtension code changes in this PR and they correctly align with RFC 8446. To aid understanding (initially for myself, but hopefully for future readers too!), I've added a brief comment to the Len() method for cookie extension on my fork to clarify the byte layout.

You can see the suggested comment in this commit:
7daac69

If you find it useful, please feel free to incorporate it.

@BRUHItsABunny
Copy link
Contributor Author

Nice contribution, I've included it. @Juktong

@mingyech How do we go forward on this PR? On my end this seems to work really well, is there anything else I should do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS cookie issue visiting URL
2 participants